Discussion:
[netcf-devel] [PATCH] make <start mode='blah'/> optional
Laine Stump
2017-03-27 04:50:52 UTC
Permalink
There's no reason to require it when defining an interface (the config
option it corresponds to is optional), and it isn't even output in the
status of an interface.
---
data/xml/interface.rng | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/data/xml/interface.rng b/data/xml/interface.rng
index 9098cc9..46818d1 100644
--- a/data/xml/interface.rng
+++ b/data/xml/interface.rng
@@ -277,17 +277,19 @@
</define>

<define name="startmode">
- <element name="start">
- <attribute name="mode">
- <choice>
- <value>onboot</value>
- <value>none</value>
- <value>hotplug</value>
- <!-- Jim Fehlig lists the following that SuSe supports:
- manual, ifplug, nfsroot -->
- </choice>
- </attribute>
- </element>
+ <optional>
+ <element name="start">
+ <attribute name="mode">
+ <choice>
+ <value>onboot</value>
+ <value>none</value>
+ <value>hotplug</value>
+ <!-- Jim Fehlig lists the following that SuSe supports:
+ manual, ifplug, nfsroot -->
+ </choice>
+ </attribute>
+ </element>
+ </optional
</define>

<!--
--
2.9.3
_______________________________________________
netcf-devel mailing list -- netcf-***@lists.fedorahosted.org
To unsubscribe send an email to netcf-devel-***@list
Eric Blake
2017-03-27 13:27:38 UTC
Permalink
Post by Laine Stump
There's no reason to require it when defining an interface (the config
option it corresponds to is optional), and it isn't even output in the
status of an interface.
---
data/xml/interface.rng | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Loading...